Koin from swift #45
Merged
Koin from swift #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the issue, with simple code!!
rodvar
requested changes
Nov 14, 2024
There was a problem hiding this comment.
@nis-ship-it well done nish! tested it on the 3 apps and works!!
Just some needs for your consideration please see my comments
.../presentation/src/iosMain/kotlin/network/bisq/mobile/presentation/di/PresentationDIHelper.kt
Outdated
Show resolved
Hide resolved
rodvar
approved these changes
Nov 14, 2024
|
@nis-ship-it cool, I've reverted the downgrade on the pods, just waiting for the CI to pass to merge 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS Main Presenter DI #42
Well can now call the koin dependencies that are registered from swift code!!