Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - koin injection under Android Node #37

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

nis-ship-it
Copy link
Contributor

Have add koin to all places, I guess?? Have test the 3 clients and works fine. The sample code could be adjusted to your needs, bare that it's just for setting up all project with koin.

@nis-ship-it
Copy link
Contributor Author

@rodvar Really sorry I forgot to tell you to not merge since I knew the androidNode wasn't building on my end, but anyway I have finished that. If you get any error, plz dm me

@rodvar
Copy link
Collaborator

rodvar commented Nov 13, 2024

@nis-ship-it no worries, it was my fault to not to test it in the androidNode - we'll learn from this and move on. Thanks for jumping quickly at it!

@rodvar rodvar merged commit c53884b into bisq-network:main Nov 13, 2024
1 check passed
@nis-ship-it nis-ship-it deleted the feature/hotfix-koinInjection branch November 13, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants