Skip to content

Commit

Permalink
Network Dashboard: Make container stop on SIGTERM
Browse files Browse the repository at this point in the history
The Docker Compose file specifies a shell script for the container entrypoint. This is necessary (at least as long as we don't use templates; see comment in `docker-compose.yaml` right above the changed line) to set up redirection for the calls to Collector Backend.

The script ends with a call to the native nginx entrypoint script. But apparently, the script running in the context of a plain shell means that SIGTERM is ignored. With this change, the entrypoint script is now invoked with `exec` which replaces the process and eliminates the problem.
  • Loading branch information
bisgardo committed Jan 2, 2024
1 parent ec39d02 commit 61a32a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion network-dashboard/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ services:
EOF
# It also looks like the entrypoint scripts come with the ability to build the config from a template
# (check out '/docker-entrypoint.d/20-envsubst-on-templates.sh').
/docker-entrypoint.sh nginx -g 'daemon off;'
exec /docker-entrypoint.sh nginx -g 'daemon off;'
ports:
- "${NETWORK_DASHBOARD_PORT-8080}:80"

0 comments on commit 61a32a5

Please sign in to comment.