Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v5 sample readme #243

Closed
wants to merge 1 commit into from
Closed

update v5 sample readme #243

wants to merge 1 commit into from

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Nov 10, 2024

follow up to d90accd

@Geal Geal requested a review from divarvel November 10, 2024 14:16
Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #243 will not alter performance

Comparing geal/update-v5-readme-json (463ac2d) with v5 (e59f41d)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (d90accd) to head (463ac2d).
Report is 4 commits behind head on v5.

Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #243      +/-   ##
==========================================
- Coverage   68.96%   68.92%   -0.04%     
==========================================
  Files          25       25              
  Lines        5922     5922              
==========================================
- Hits         4084     4082       -2     
- Misses       1838     1840       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@divarvel
Copy link
Collaborator

oh sorry i missed it and fixed it in #244

it looks a bit different because of flaky coverage checks

@divarvel divarvel closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants