-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for third party block reuse #230
base: v5
Are you sure you want to change the base?
Conversation
I'm not decided yet on the best name for the functions still allowing the old format, between |
CodSpeed Performance ReportMerging #230 will not alter performanceComparing Summary
|
I’d go for the most explicit. I read |
I think we should document the signature scheme to make a few things clearer:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #230 +/- ##
==========================================
+ Coverage 68.96% 69.70% +0.74%
==========================================
Files 25 25
Lines 5922 5945 +23
==========================================
+ Hits 4084 4144 +60
+ Misses 1838 1801 -37 ☔ View full report in Codecov by Sentry. |
This changes the third party block signature format to prevent reuse of third party blocks across tokens, by including the previous block's signature in the signed data