-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ecdsa signatures #108
base: v5
Are you sure you want to change the base?
Conversation
Geal
commented
Oct 11, 2022
•
edited
Loading
edited
- Support for ECDSA signatures on curve secp256r1 biscuit#165
Since we can now have multiple algorithms, we cannot know during deserialization the right size of a signature, so that check is now removed. A signature with an invalid size will generate an error later during verification anyway
CodSpeed Performance ReportMerging #108 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #108 +/- ##
==========================================
+ Coverage 67.91% 68.18% +0.27%
==========================================
Files 25 27 +2
Lines 5507 5689 +182
==========================================
+ Hits 3740 3879 +139
- Misses 1767 1810 +43 ☔ View full report in Codecov by Sentry. |