refactor the builder API to avoid symbol table manipulation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the builder API was using symbol tables internally, which meant that datalog elements were converted too early, and tat made the API too complicate. This aligns the builder implementation with the approach use in the rust implementation, where the builder types only contain other builder types, and the conversion with the symbol table is only done when calling the build() method. This also removes some functions from the public API that could be misused to get invalid symbol tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the builder API was using symbol tables internally, which meant that datalog elements were converted too early, and that made the API too complicate. This aligns the builder implementation with the approach use in the rust implementation, where the builder types only contain other builder types, and the conversion with the symbol table is only done when calling the build() method.
This also removes some functions from the public API that could be misused to get invalid symbol tables, and fixes some parser precedence issues