Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4 format features #146

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Version 4 format features #146

wants to merge 28 commits into from

Conversation

yaronf
Copy link
Contributor

@yaronf yaronf commented Jun 16, 2024

This PR implements several v4 format features:

  • New bitwise operators
  • Not equal operator
  • "check all"

Along the way I solved several bugs and added some unit tests.

  • Support negative literals.
  • Allow (quoted) double-quote character in strings
  • Add testing for unary length (and clarify the operator's semantics)
  • Debugger: print sets correctly
  • Fix missing error check

Since this is a very large PR, I suggest to review it commit by commit.

Also, since it still doesn't implement all of the v4 format, please merge it into a separate branch for now.

Lastly, just like #142, this implementation does not minimize the version number when serializing. I need your help in understanding the relevant code.

@seh
Copy link
Contributor

seh commented Oct 28, 2024

Is this patch still viable for making it in? I don't see anyone having reviewed it yet.

@divarvel
Copy link
Contributor

it has not been reviewed yet indeed.

based on the description, it still needs a bit of work on the block version selection before being merged.
As for merging partial support of the v4 blocks, it could be ok, depending on the missing features, but that will required a thorough review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants