Parameters #122
Merged
Parameters #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsed datalog snippets can now contain placeholders (for instance: `check if right({resource}, {operation}`). This allows embedding dynamic values in datalog, without the risk of injections.
All the `FromString*` methods now have a `FromString*WithParams` counterpart that take an extra
`map[string]Term` value.
/!\ For now, it is the caller's responsibility to make sure the all the placeholders **in expressions** have a corresponding value defined (same as making sure sets don't contain variables).
Placeholders set in predicates don't have this issue. This is an underlying issue of the parser; it was not introduced by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsed datalog snippets can now contain placeholders (for instance:
check if right({resource}, {operation}). This allows embedding dynamic values in datalog, without the risk of injections.All the
FromString*methods now have aFromString*WithParamscounterpart that take an extramap[string]Termvalue./!\ For now, it is the caller's responsibility to make sure the all the placeholders in expressions have a corresponding value defined (same as making sure sets don't contain variables).
Placeholders set in predicates don't have this issue. This is an underlying issue of the parser; it was not introduced by this change.