Snapshots #8
Merged
Snapshots #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error reporting for datalog evaluation is missing (reporting failed checks and policies in the snapshot and extra authorizer code, syntax errors in extra authorizer code and query)
- `dump_code()` does not provide a stable order for facts, so facts can jump around when typing a query or extra authorizer code - `to_string()` provides the origin of facts as comments, instead of obscuring it The issue is that `to_string()` does not display authorizer facts and rules, unless we call `authorize()` first, so that's what we do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given a base64-encoded snapshot: