Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: lower numpy requirement from 2.0 to 1.25 to allow biotite ins… #11

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Croydon-Brixton
Copy link
Contributor

Hi @padix-key --
here's a quick hotfix to lower the version requirement for numpy to 1.25, as it otherwise leads to a version conflict when installing the latest biotite v1.0.0 release
(c.f. https://github.com/biotite-dev/biotite/blob/main/pyproject.toml#L25-L26)

@padix-key
Copy link
Member

padix-key commented Aug 28, 2024

Thanks for the fix! This is some oversight from our side. @JHKru Do we want to release a patch version immediately after merge? I assume this might affect a lot of users.

@padix-key padix-key merged commit 9dab55d into biotite-dev:main Aug 28, 2024
16 checks passed
@JHKru
Copy link
Member

JHKru commented Aug 28, 2024

Yes, sure; sorry for the late reply.

@BartoszJanuszNA
Copy link

BartoszJanuszNA commented Sep 18, 2024

Hi! Sorry for digging it up, but don't you think you should also lower the numpy version in [build-system] requires section? I am having conflicts in my project because of that.

The conflict is caused by:
    biotite 1.0.0 depends on numpy>=1.25
    proteinmpnn 0.1.0 depends on numpy<2.0
    biotraj 1.2.0 depends on numpy>=2.0
    biotite 1.0.0 depends on numpy>=1.25
    biotraj 1.1.0 depends on numpy>=2.0

@padix-key
Copy link
Member

The [build-system] section lists only requirements for building the package, so it does not affect the dependencies for the actual environment. However, version 1.2.0 had a wrong version pin in the dependencies section. For that reason 1.2.1 was released, which relaxed numpy >= 1.25, but this biotraj version is not listed in your output. Which package manager are you using?

@BartoszJanuszNA
Copy link

You are right, pip was not picking up biotraj 1.2.1 because of scipy version conflict with another of my dependencies, and was giving me misleading error. I managed to resolve it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants