Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore Update optlang to 1.5 #281

Closed
wants to merge 4 commits into from
Closed

Chore Update optlang to 1.5 #281

wants to merge 4 commits into from

Conversation

carrascomj
Copy link
Member

@carrascomj carrascomj commented Jul 21, 2021

Related to DD-DeCaF/modeling-base#9 and opencobra/cobrapy#1011

Description

optlang was upgraded to version >=1.5, mirroring cobrapy (which was pinned to >= 0.22, the MRV for optlang 1.5). This removes some warnings and leaves cameo up to date with cobrapy.

Implementation

  • Requirements for optlang>=1.5 and cobrapy>=0.22.0.
  • Rewrote iJO1366 pickle test file so that it can be deserialized with pickle into a optlang1.5 object (the tolerances attribute was making it fail).

iJO1366.pickle was generated with the following snippet:

```python
import pickle
import cobra

model = cobra.io.read_sbml_model("tests/data/iJO1366.xml")
with open("tests/data/iJO1366.pickle", "wb") as f:
  pickle.dump(model, f)
```
@carrascomj carrascomj mentioned this pull request Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #281 (16cd163) into devel (9f5eddd) will not change coverage.
The diff coverage is n/a.

❗ Current head 16cd163 differs from pull request most recent head 0b0ec48. Consider uploading reports for the commit 0b0ec48 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #281   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files          58       58           
  Lines        5576     5576           
  Branches      949      949           
=======================================
  Hits         3582     3582           
  Misses       1789     1789           
  Partials      205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5eddd...0b0ec48. Read the comment docs.

@carrascomj
Copy link
Member Author

Closing since it was resolved upstream.

@carrascomj carrascomj closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant