feat(lint): support promise expression in noFloatingPromises

[kaykdm]

Summary

related: #3187 and #4956
This pull request introduces the support for promise expressions in noFloatingPromises

Example of invalid code:

const promise = new Promise((resolve) => resolve('value'));
promise.then(() => { }).finally(() => { });

Promise.resolve('value').then(() => { })
Promise.all([p1, p2, p3])

Example of valid code:

const promise = new Promise((resolve) => resolve('value'));
promise.then(() => { }, () => { })

Promise.resolve('value').catch(() => {})
await Promise.all([p1, p2, p3])

[codspeed-hq]

CodSpeed Performance Report

Merging #4977 will not alter performance

_{Comparing kaykdm:support-promise-expression (71696d7) with next (d76e8d3)}

Summary

✅ 95 untouched benchmarks

[ematipico]

Looking good! There are other cases we need to cover regarding the Promise global

[ematipico]

Suggested change

	is_variable_initializer_a_promise(&js_var_decl).unwrap_or(false)
	|| is_variable_annotation_a_promise(&js_var_decl).unwrap_or(false),
	is_variable_initializer_a_promise(&js_var_decl).unwrap_or_default()
	|| is_variable_annotation_a_promise(&js_var_decl).unwrap_or_default(),

[kaykdm]

updated!

[ematipico]

Suggested change

	if is_handled_promise(&js_call_expression).unwrap_or(false) {
	if is_handled_promise(&js_call_expression)? {

[kaykdm]

I actually want to return only when the value is true and continue when the value is false or None so using ? does not work here

[ematipico]

Suggested change

	is_expression_an_promise(&js_ident_expr).unwrap_or(false)
	|| is_binding_a_promise(&js_ident_expr, model).unwrap_or(false),
	is_expression_an_promise(&js_ident_expr).unwrap_or_default()
	|| is_binding_a_promise(&js_ident_expr, model).unwrap_or_default(),

[kaykdm]

updated!

[ematipico]

So, there are few things that we need to handle here (not just here, but in all cases where we check "Promise"):

1. The parenthesis. Unfortunately these are valid cases e.g. return (new Pormise.resolve()). You can use the method .omit_parentheses that can be used from AnyJsExpression
2. Global identifiers. A promise can be used from window.Promise or globalThis.Promise. You can use the utility global_identifier
3. Making sure that Promise isn't a binding. You need to use the semantic model to check that.

var Promise = { resolve(): {} };
return Promise.resolve()

This should NOT trigger the rule.
Here's an example of rust code to check:

biome/crates/biome_js_analyze/src/lint/suspicious/no_prototype_builtins.rs

Lines 209 to 214 in 738ad51

	fn is_global_object(semantic: &SemanticModel) -> bool {
	semantic
	.scopes()
	.find(|s| s.get_binding("Object").is_some())
	.map_or(true, |s| s.is_global_scope())
	}

[kaykdm]

Thank you for the feedback!
I have updated the code to handle 1 and 2. I will probably work on 3 tomorrow.

[kaykdm]

1. The parenthesis. Unfortunately these are valid cases e.g. return (new Pormise.resolve()). You can use the method .omit_parentheses that can be used from AnyJsExpression
2. Global identifiers. A promise can be used from window.Promise or globalThis.Promise. You can use the utility global_identifier
3. Making sure that Promise isn't a binding. You need to use the semantic model to check that.

I have updated the code to cover all the cases.
For 3 (making sure that Promise isn't a binding), creating a function like is_global_object for Promise does not work for globally defined variable. Therefore, I decided to use model.binding instead.