refactor(noFloatingPromises): update functions to return Option

[kaykdm]

Summary

related: #4956

This PR refactors functions to return Option, aligning with the accepted coding practices in Biome as suggested here

[codspeed-hq]

CodSpeed Performance Report

Merging #4970 will improve performances by 6.95%

_{Comparing kaykdm:refactor-noFloatingPromises (5dd7d53) with next (e750523)}

Summary

⚡ 1 improvements
✅ 94 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	react.production.min_3378072959512366797.js[cached]	2 ms	1.9 ms	+6.95%

[ematipico]

Thank you! Much better!

Just to give more information about this "style" of programming: our parsers are recoverable and error resilient, this means that even incorrect syntax will emit an analyzable CST.

Because of that we need to assume that each node/token are incorrect. Bogus nodes for nodes, missing mandatory tokens for tokens.

Inside lint rules, when we use .ok()?, it means that we "query a valid node", and we skip (via the try operator) possible bogus nodes/missing mandatory tokens.

I hope it makes sense! 😊

[arendjr]

Nit: I think this could have been written more concisely as:

                AnyJsBindingDeclaration::JsVariableDeclarator(js_var_decl) =>
                    is_variable_initializer_a_promise(&js_var_decl).or_else(
                        || is_variable_annotation_a_promise(&js_var_decl)
                    ),

Note this would propagate the None state up to the caller, but that's also the point of having these functions return Option. Don't worry about it though, you'll get the hang of this style of Rust utilities soon enough 👍

[kaykdm]

Thanks for the suggestion! I'll incorporate that change in the next PR.