fix(lint): don't report missing dependency on incomplete statement #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
1 task
ematipico
approved these changes
Jan 9, 2025
arendjr
changed the title
CodSpeed Performance ReportMerging #4864 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test case for #4567 . It appears the panic was already fixed, so I didn't have to do much for it. But I did notice an error was reported on the hook call, while the statement itself is not even complete in the given snippet. In practice, I think this means people may see the error appear while they're still writing the code, which seems not very user-friendly. So all I did was disable the error in this case.
Seeing how small this change is, I don't even think it warrants a CHANGELOG entry 😅
Test Plan
Test case added.