Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): don't panic on incomplete code in noFallthroughSwitchClause #4863

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jan 9, 2025

Summary

Fixes #4566.

Test Plan

Test case added.

@arendjr arendjr requested review from a team January 9, 2025 09:17
@arendjr arendjr changed the base branch from main to next January 9, 2025 09:17
@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jan 9, 2025
@arendjr arendjr changed the title Fix no fallthrough switch case panic fix(lint): don't panic on incomplete code in noFallthroughSwitchClause Jan 9, 2025
@arendjr arendjr force-pushed the fix-no-fallthrough-switch-case-panic branch from bf60907 to 42affae Compare January 9, 2025 09:26
@ematipico
Copy link
Member

Remember to add changesets when fixing user facing code

@arendjr arendjr merged commit 846e4a4 into biomejs:next Jan 9, 2025
11 checks passed
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #4863 will not alter performance

Comparing arendjr:fix-no-fallthrough-switch-case-panic (31dd766) with next (12e3936)

Summary

✅ 95 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Panic internal error: entered unreachable code: Missing switch clause
2 participants