Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css_parser): don't panic on unexpected EOF #4862

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(css_parser): don't panic on unexpected EOF #4862

merged 1 commit into from
Jan 9, 2025

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jan 9, 2025

Summary

Fixes the panic we see when running pnpm check in our own repo.

Test Plan

Add test cases.

@arendjr arendjr requested review from a team January 9, 2025 08:11
@github-actions github-actions bot added A-Parser Area: parser L-CSS Language: CSS labels Jan 9, 2025
@arendjr arendjr merged commit 12e3936 into biomejs:next Jan 9, 2025
11 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #4862 will not alter performance

Comparing arendjr:fix-css-parser-crash (e733d6e) with next (ec02891)

Summary

✅ 95 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Parser Area: parser L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arendjr