fix(useSortedClasses): should suggest code fixes that match the JSX quote style of the formatter #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
ematipico
reviewed
Jan 8, 2025
crates/biome_analyze/src/context.rs
Outdated
| @@ -17,6 +17,7 @@ pub struct RuleContext<'a, R: Rule> { | |||
| file_path: &'a Path, | |||
| options: &'a R::Options, | |||
| preferred_quote: &'a PreferredQuote, | |||
| preferred_jsx_quote: Option<&'a PreferredQuote>, | |||
There was a problem hiding this comment.
Like preferred_quote, field (line 19) it shouldn't be a Option
crates/biome_analyze/src/context.rs
Outdated
Comment on lines
176
to
177
| self.preferred_jsx_quote | ||
| .expect("preferred_jsx_quote should be provided") |
There was a problem hiding this comment.
When you remove the Option, you can remove expect
CHANGELOG.md
Outdated
| @@ -15,6 +15,10 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b | |||
|
|
|||
| ### Analyzer | |||
|
|
|||
| #### New features | |||
|
|
|||
| - The analyzer now infers the correct JSX quote style from `javascript.formatter.jsxQuoteStyle`, so code fixes will use the same quote style as the formatter. Contributed by @lucasweng | |||
There was a problem hiding this comment.
That isn't true, though. In this PR you just fixed useSortedClasses, but there are many JSX-related rules that don't use this new feature yet. You're free to implement it in another PR if you want. As for now, we can remove this line
CodSpeed Performance ReportMerging #4857 will not alter performanceComparing Summary
|
lucasweng
changed the title
|
Thank you @ematipico! I’ve made some updates based on your comments:2673601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
preferred_jsx_quoteto the analyzer. It is used only inside the JavaScript analyzer to ensure that code fixes match the JSX quote style specified in the formatter’s configuration.useSortedClassesrule to use this new logic.Test Plan