fix(parser/html): misc minor parsing fixes #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
arendjr
reviewed
Jan 7, 2025
crates/biome_html_parser/tests/html_specs/error/element/missing-element-name.html.snap
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #4852 will not alter performanceComparing Summary
|
dyc3
force-pushed
the
html-misc-minor-fixes
branch
2 times, most recently
from
f706eed to
0566679
Compare
ematipico
reviewed
Jan 7, 2025
dyc3
force-pushed
the
html-misc-minor-fixes
branch
from
0566679 to
373a8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains some parsing fixes aimed at improving the number of prettier tests that parse successfully. It also has some improvements to emitted diagnostics, and some minor refactors.
Test Plan
Added some test cases.