Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(noNodejsModules): ignore type-only imports #3674

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Conaclos
Copy link
Member

Summary

Partially fix #1674

Test Plan

I added some tests.

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Aug 18, 2024
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48503 48503 0
Passed 47306 47306 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.53% 97.53% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6561 6561 0
Passed 2201 2201 0
Failed 4360 4360 0
Panics 0 0 0
Coverage 33.55% 33.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 670 670 0
Passed 598 598 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.25% 89.25% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18386 18386 0
Passed 14074 14074 0
Failed 4312 4312 0
Panics 0 0 0
Coverage 76.55% 76.55% 0.00%

@Conaclos Conaclos merged commit 3b248b3 into main Aug 18, 2024
15 checks passed
@Conaclos Conaclos deleted the conaclos/noNodejsModules-type-only-imports branch August 18, 2024 13:09
Copy link

codspeed-hq bot commented Aug 18, 2024

CodSpeed Performance Report

Merging #3674 will not alter performance

Comparing conaclos/noNodejsModules-type-only-imports (50d8733) with main (ffb66d9)

Summary

✅ 101 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
1 participant