refactor: move useImportRestrictions into noRestrictedImports (#4509

)
biomejs · Nov 27, 2024 · 39edbf2 · 39edbf2
1 parent 0d75b28
commit 39edbf2
Show file tree

Hide file tree

Showing 14 changed files with 323 additions and 255 deletions.
diff --git a/...geset/the_rule_useimportrestrictions_has_been_moved_into_norestrictedimports.md b/...geset/the_rule_useimportrestrictions_has_been_moved_into_norestrictedimports.md
@@ -0,0 +1,26 @@
+---
+cli: major
+---
+
+# The rule `useImportRestrictions` has been removed and replaced with an option in `noRestrictedImports`
+
+To avoid confusion between the two similarly named rules, `useImportRestrictions` has been removed
+and replaced with the option `restrictPackagePrivate` in the `noRestrictedImports` rule:
+
+```jsonc
+// biome.json
+{
+  "linter": {
+    "rules": {
+      "nursury": {
+        "noRestrictedImports": {
+          "level": "error",
+          "options": {
+            "restrictPackagePrivate": "all"
+          }
+        }
+      }
+    }
+  }
+}
+```
diff --git a/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs b/crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
diff --git a/crates/biome_js_analyze/src/lint/nursery.rs b/crates/biome_js_analyze/src/lint/nursery.rs
@@ -37,7 +37,6 @@ pub mod use_explicit_type;
 pub mod use_google_font_display;
 pub mod use_google_font_preconnect;
 pub mod use_guard_for_in;
-pub mod use_import_restrictions;
 pub mod use_sorted_classes;
 pub mod use_strict_mode;
 pub mod use_trim_start_end;
@@ -82,7 +81,6 @@ declare_lint_group! {
             self :: use_google_font_display :: UseGoogleFontDisplay ,
             self :: use_google_font_preconnect :: UseGoogleFontPreconnect ,
             self :: use_guard_for_in :: UseGuardForIn ,
-            self :: use_import_restrictions :: UseImportRestrictions ,
             self :: use_sorted_classes :: UseSortedClasses ,
             self :: use_strict_mode :: UseStrictMode ,
             self :: use_trim_start_end :: UseTrimStartEnd ,