refactor: convert clippy allows to clippy expects (#4791)

Co-authored-by: 12ball <[email protected]>
Co-authored-by: Carson McManus <[email protected]>

Cargo.toml

@@ -13,6 +13,7 @@ unused_lifetimes                       = "warn"
 unused_macro_rules                     = "warn"
 
 [workspace.lints.clippy]
+allow_attributes        = "deny"
 cargo_common_metadata   = "allow"
 empty_docs              = "allow" # there are some false positives inside biome_wasm
 multiple_crate_versions = "allow"

crates/biome_analyze/src/context.rs

@@ -24,7 +24,7 @@ impl<'a, R> RuleContext<'a, R>
 where
     R: Rule + Sized + 'static,
 {
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub fn new(
         query_result: &'a RuleQueryResult<R>,
         root: &'a RuleRoot<R>,

crates/biome_analyze/src/rule.rs

@@ -445,7 +445,7 @@ macro_rules! declare_lint_rule {
         // This is implemented by calling the `group_category!` macro from the
         // parent module (that should be declared by a call to `declare_group!`)
         // and providing it with the name of this rule as a string literal token
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! rule_category {
             () => { super::group_category!( $name ) };
         }
@@ -497,7 +497,7 @@ macro_rules! declare_syntax_rule {
         // This is implemented by calling the `group_category!` macro from the
         // parent module (that should be declared by a call to `declare_group!`)
         // and providing it with the name of this rule as a string literal token
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! rule_category {
             () => { super::group_category!( $name ) };
         }
@@ -564,7 +564,7 @@ macro_rules! declare_source_rule {
         );
 
         /// This macro returns the corresponding [ActionCategory] to use inside the [RuleAction]
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! rule_action_category {
             () => { ActionCategory::Source(SourceActionKind::Other(Cow::Borrowed(concat!($language, ".", $name) )))  };
         }
@@ -609,7 +609,7 @@ macro_rules! declare_lint_group {
         // name within this group.
         // This is implemented by calling the `category_concat!` macro with the
         // "lint" prefix, the name of this group, and the rule name argument
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! group_category {
             ( $rule_name:tt ) => { $crate::category_concat!( "lint", $name, $rule_name ) };
         }
@@ -646,7 +646,7 @@ macro_rules! declare_assists_group {
         // name within this group.
         // This is implemented by calling the `category_concat!` macro with the
         // "lint" prefix, the name of this group, and the rule name argument
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! group_category {
             ( $rule_name:tt ) => { $crate::category_concat!( "assists", $name, $rule_name ) };
         }
@@ -683,7 +683,7 @@ macro_rules! declare_syntax_group {
         // name within this group.
         // This is implemented by calling the `category_concat!` macro with the
         // "lint" prefix, the name of this group, and the rule name argument
-        #[allow(unused_macros)]
+        #[expect(unused_macros)]
         macro_rules! group_category {
             ( $rule_name:tt ) => { $crate::category_concat!( "syntax", $name, $rule_name ) };
         }

crates/biome_analyze/src/services.rs

@@ -32,7 +32,7 @@ impl MissingServicesDiagnostic {
 }
 
 pub trait FromServices: Sized {
-    #[allow(clippy::result_large_err)]
+    #[expect(clippy::result_large_err)]
     fn from_services(
         rule_key: &RuleKey,
         services: &ServiceBag,

crates/biome_aria_metadata/build.rs

@@ -236,7 +236,6 @@ enum AriaAttributeType {
 
 #[derive(Debug, Default, biome_deserialize_macros::Merge, serde::Deserialize)]
 #[serde(rename_all = "camelCase")]
-#[allow(dead_code)]
 struct ValueDefinition {
     description: String,
     is_default: bool,

crates/biome_cli/src/service/mod.rs

@@ -422,7 +422,7 @@ struct JsonRpcRequest<P> {
 #[derive(Debug, Deserialize)]
 #[serde(deny_unknown_fields)]
 struct JsonRpcResponse {
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     jsonrpc: Cow<'static, str>,
     id: u64,
     result: Option<Box<RawValue>>,
@@ -431,10 +431,10 @@ struct JsonRpcResponse {
 
 #[derive(Debug, Deserialize)]
 struct JsonRpcError {
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     code: i64,
     message: String,
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     data: Option<Box<RawValue>>,
 }
 

crates/biome_cli/tests/commands/format.rs

@@ -180,14 +180,10 @@ const APPLY_ATTRIBUTE_POSITION_AFTER: &str = r#"<Foo
 </Foo>;
 "#;
 
-// Without this, Test (windows-latest) fails with: `warning: constant `DEFAULT_CONFIGURATION_BEFORE` is never used`
-#[allow(dead_code)]
 const DEFAULT_CONFIGURATION_BEFORE: &str = r#"function f() {
     return { a, b }
   }"#;
 
-// Without this, Test (windows-latest) fails with: `warning: constant `DEFAULT_CONFIGURATION_AFTER` is never used`
-#[allow(dead_code)]
 const DEFAULT_CONFIGURATION_AFTER: &str = "function f() {
       return { a, b };
 }

crates/biome_configuration/src/editorconfig.rs

@@ -144,7 +144,7 @@ pub enum EditorconfigValue<T> {
 }
 
 // This is an `Into` because implementing `From` is not possible because you can't implement traits for a type you don't own.
-#[allow(clippy::from_over_into)]
+#[expect(clippy::from_over_into)]
 impl<T: Default> Into<Option<T>> for EditorconfigValue<T> {
     fn into(self) -> Option<T> {
         match self {

crates/biome_css_analyze/src/lint/suspicious/no_shorthand_property_overrides.rs

@@ -105,7 +105,7 @@ impl Visitor for NoDeclarationBlockShorthandPropertyOverridesVisitor {
                         .and_then(|property_node| property_node.name().ok())
                     {
                         let prop = prop_node.text();
-                        #[allow(clippy::disallowed_methods)]
+                        #[expect(clippy::disallowed_methods)]
                         let prop_lowercase = prop.to_lowercase();
 
                         let prop_prefix = vender_prefix(&prop_lowercase);

crates/biome_css_analyze/tests/spec_tests.rs

@@ -99,7 +99,7 @@ fn run_test(input: &'static str, _: &str, _: &str, _: &str) {
     }
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 pub(crate) fn analyze_and_snap(
     snapshot: &mut String,
     input_code: &str,

crates/biome_css_formatter/src/css/bogus/mod.rs

@@ -1,6 +1,6 @@
 //! This is a generated file. Don't modify it by hand! Run 'cargo codegen formatter' to re-generate the file.
 
-#[allow(clippy::module_inception)]
+#[expect(clippy::module_inception)]
 pub(crate) mod bogus;
 pub(crate) mod bogus_at_rule;
 pub(crate) mod bogus_block;