GroupBy: Avoid guessing variable types #6906
Draft
+177
−77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Group By widget will fail on Pandas 3.0.
Group by currently computes aggregations, puts them into a pandas data frame and then guesses data types - at least in part. In particular, it tries to interpret columns as time and creates a
TimeVariable
if conversion succeeds. In tests, we have a concatenation of numeric data that results in value "1.0 1.0". Pandas 3.0 now converts this to January 1st 1970 (I think), so the column becomes a time variable and appears among primitive attributes, not metas(!).Description of changes
I think a proper solution is to define how to construct variables with aggregations. It can be
StringVariable
for concatenation,ContinuousVariable
for Span...)The difference between the latter two cases is that it resets the number of decimals.
I modified one test. Apparently it assumes that Count and Count Defined for string variables will be metas, but as far as I see, they are attributes. This PR keeps the behaviour, so I don't understand why tests were failing before.
Includes