-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed settings #4721
base: master
Are you sure you want to change the base?
Typed settings #4721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4721 +/- ##
==========================================
- Coverage 86.24% 83.68% -2.56%
==========================================
Files 300 275 -25
Lines 61027 55609 -5418
==========================================
- Hits 52634 46539 -6095
- Misses 8393 9070 +677 |
af8cbc4
to
f9ed95b
Compare
if version < 3: | ||
sel = context.values["selection"] | ||
context.values["selection"] = ([(name, vtype + 100) | ||
for name, vtype in sel], -3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration is removed because annotated settings are no longer encoded into tuples. DomainContextHandler
thus performs an exactly opposite migration for all annotated settings. If this migration here is left in, it would "unmigrate" the setting.
I assume such cases like this will be rare. So although this situation could be avoided if DomainContextHandler
performed the migration after calling migrate_context
, the downside would be that this would force the future migrate_context
to work with raw, encoded settings instead of simpler, decoded, and thus force them to "understand" how coding is done - which should be of no concern to migrations.
a4dac2d
to
cd56830
Compare
4c3c8a5
to
75489ff
Compare
Issue
Uses changes from biolab/orange-widget-base#62.
Changes in projections are given as an example of kinds of annotations that will be required from widgets to avoid warnings and allow storing their settings as json.
Includes