Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp maintenance (2024-05) #690

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented May 23, 2024

Summary

  • dependency: react-router 4
    • Reverted, to be tried again at a later date.
  • dev-dependency: css-loader 7
  • dev-dependency: sass-loader 14
  • dev-dependency: style-loader 4
  • dev-dependency: webpack-dev-server 5
  • npm update so that other dependencies are refreshed
  • npm update on webcore
  • Require a minimum of Node.js 18 to build the webapp

Copy link
Collaborator

@tiberio-baptista tiberio-baptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webapp continues to work as intended, with these new changes.

Looks good for me!

@Enet4
Copy link
Collaborator Author

Enet4 commented Aug 8, 2024

We've been testing the webapp with these changes for a while. For the most part things seem to be in good order.
However, we currently depend on react-router in one of our web plugins so that it can navigate back to the search page. With the updates of react-router, hashHistory is no longer available. We may need to identify a migration path, making changes here if necessary.

@bastiao
Copy link
Member

bastiao commented Aug 27, 2024

We've been testing the webapp with these changes for a while. For the most part things seem to be in good order. However, we currently depend on react-router in one of our web plugins so that it can navigate back to the search page. With the updates of react-router, hashHistory is no longer available. We may need to identify a migration path, making changes here if necessary.

This will be on-hold until this situation is solved.

@Enet4 Enet4 marked this pull request as draft October 17, 2024 20:23
- react-router 4
- css-loader 7
- sass-loader 14
- style-loader 4
- webpack-dev-server 5
- npm update
- css-loader 7
- sass-loader 14
- style-loader 4
- webpack-dev-server 5
- npm update
- provide react-router-dom instead of react-router
  via external require
No longer used
@Enet4 Enet4 force-pushed the chore/webapp-maintenance-2024-05 branch from e725818 to f011b67 Compare November 11, 2024 09:31
@Enet4 Enet4 marked this pull request as ready for review November 11, 2024 09:31
@Enet4
Copy link
Collaborator Author

Enet4 commented Nov 11, 2024

I have decided to revert the upgrade of react-router so that it can be worked on separately. When doing so, we must not forget to test for routing capabilities within a web UI plugin.

I'm thinking that at the same time we should try a better React integration again, one which does not force us to create multiple rendering contexts.

@Enet4 Enet4 requested a review from bastiao November 11, 2024 09:36
@Enet4 Enet4 force-pushed the chore/webapp-maintenance-2024-05 branch from f011b67 to dda4b99 Compare November 11, 2024 09:38
- keep using version 3
  while we do not have a way for routing to work in web UI plugins
@Enet4 Enet4 force-pushed the chore/webapp-maintenance-2024-05 branch from dda4b99 to 17b5c3c Compare November 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants