Change DICOM storage stop behavior to soft stop #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- let the index queue worker thread finish processing all items in queue before exiting - do not interrupt ongoing indexing tasks
|
Putting this on hold because an index worker thread already waiting on |
- periodically poll from priority queue instead of take, giving the thread an opportunity to exit after DICOM storage was stopped
|
Mostly replaced There is also room for implementing a hard stop in the future, should we ever want that. |
|
after discussion, we decided to reuse the thread. |
- move IndexQueueWorker to a dedicated class - start index worker thread when needed - do not halt index worker thread when service is stopped
|
I can say that this is working as intended now. Indexing continues to work for a TCP connection, even if the storage service is stopped midway. Subsequent TCP connections are not possible, as expected. |
tiberio-baptista
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#664 introduced a mechanism which stops the DICOM storage service's indexer worker thread when the service is stopped by request. An unwanted side-effect of this is that stopping the storage service will halt any pending requests to index files already in storage, leaving them in the state of stored but not indexed.
Summary