Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in CSV export code & docs #683

Conversation

tiberio-baptista
Copy link
Collaborator

This quick PR fixes a typo present in Dicoogle's REST API pertaining to CSV exporting:

  • The endpoint /export/cvs was changed to /export/csv;
  • Related methods/code were refactored;
  • The API docs were updated accordingly.

@Enet4
Copy link
Collaborator

Enet4 commented Jan 2, 2024

We should not bother changing that endpoint. It is obsolete since Dicoogle version 2, so we are better off removing it entirely in future versions.

If I'm not mistaken, you are looking for POST /exportFile, available in dicoogle-client as issueExport, then GET /exportFile to download the CSV file.

@Enet4 Enet4 closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants