Webapp maintenance #674
Merged
Webapp maintenance #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current failure with Node.js 21 is caused by a bug in the Dart compiler: dart-lang/sdk#53784 (depended on for Sass compilation) |
- npm update - upgrade to v3
- npm update - upgrade lock file version to v3
- Node.js 16 - npm 7
- babel-loader - eslint-webpack-plugin 4 - rimraf 5 - sass-loader 13 - webpack-cli 5
We were not using these dependencies effectively, and was a burden when working on other parts of the repository (#406)
- due to unexpected breaking change in v5.2.4
Enet4
force-pushed
the
chore/webapp/maintenance-2023
branch
from
9a9c1b9
to
e0691ff
Compare
npm update
|
Leaving a note that this PR was tested and approved by @tiberio-baptista. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates several dependencies and ensures the presence of the latest
dicoogle-client5.2.x in the webapp.Requires Node.js >=16 to build the webapp (which everyone should have by now anyway).