Feature: Align to AgroPortal 3.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove no more used mappings code * Fix: use multilingual helper to select the right label to show in search page (#735) * use multilingual helper to select the right label to show in search page * extract search_concept_label helper to re-use in concept jump to * change submission anchor to class, because can used multiple time in same page
* use color gem to generate better colors for skos collections * replace chosen with tomselect in the collections and scheme selector * remove jquery chosen files
* fix: home annotator block redirection to annotator page with empty text (#629) * Fix: Download button in summary export metadata (#628) * fix xml download button in summary page, export metadata * adjust the position of the export metadata download button and make the hover cursor pointer for it * Fix: the contexual json icon for to the concept adapt to the select tab (#539) * refactor concepts json code and put it in a stimulus controller * adjust the position of the concepts json link * remove non related code to concepts json PR * remove non related code to contextual json pull request * pass base class URL directly to concepts json stimulus controller * clean concepts json stimulus code * remove undesired code from concepts json button PR * fix typo in agent_search_input_component.html.haml * rename concepts json button stimulus controller * clean concepts json button controller code * clean concepts json button related code --------- Co-authored-by: Syphax bouazzouni <[email protected]> Co-authored-by: Bilel KIHAL <[email protected]> Co-authored-by: @SirineMhedhbi * feature: make view of clickable in summary page header (#643) * feature: use the ontologies selector by name and acronym in edit groups and categories (#641) * Fix: Reject the current ontology from appearing in the ontologies selector in editing the submission's relations (#640) * reject current ontology from the ontologies selector in relations section - edit submission * pass reject ontology as a param in generate ontology seect input method * Feature: Make text area resisable in upload ontology and edit submission forms (#644) * make text areas resisable in upload ontology and edit submission forms * make forms list input text areas resisable * Fix: The issue when the agent has no acronym (#645) * fix the issue when the agent has no acronym * clean agent affiliations combination * fix: the concepts chips links redirecting to the wrong destination (#638) * Feature: Scroll to the selected term in the tree view component (#646) * scroll to the selected term in the tree view * prevent the whole page scrolling when centring the scroll to the selected tree view element * fix: change local test "URL" to "URI" in check resolvability components (#651) * Feature: Add content negotiation redirection tests (#622) * Add uri redirection for /ontologies/:acronym/:id to the appropriate page * small fixes: remove binding.pry and return resource_id in find_type_by_search * Add copy agroportal link functionality - this functionality is using the ClipboardComponent because it works the same but differ only in the content and icon - the clipboard component has been changed to accept title and icon * redirect to content finder page when no type is valid * Updated route to use redirect action instead of show_redirection * Use default icon and title arguments in the Clipboard Component * rename and internationalize clipboard component titles * small fix: remove % from svg icon * Add the copy title to the components section in en.yml and fr.yml * Show the generated uri when user hover over the copy link icon * Make the dynamic route content negotiable - based on the accept header we will - if "text/html" we will redirect to the agroportal page - else we will call the api and get the content serialized in the format specified and return it * update serialize content to return accept_header * translate copy_original_uri and copy_portal_uri to french * reuse search content concern in uri redirection concern * remove duplicate link_last_part method * Add htaccess functionality * Add apache and nginx instruction for htaccess redirection * Clean te code in the view file * Add OntologiesRedirectionController - remove redirect and generate_htaccess from ontologies_controller - clean code the generate_htaccess method - add "ontology_portal_uri" in @Identifiers * Regroupe routes * Make ontologies_redirection controller and refactor generate_htaccess code * Internationalization of redirection rewrite rules modal * Add note for url that has # * link contact support button to the feedback page * Change regex to redirect only url of type: /path/resource_id - for urls that has the # it will redirect to the ontology page * Add ontology redirection based on the accept header format * move the ontology redirection route to the bottom to have less priority * Change rewrite rules note using alert component * Add /ontologies/ACRONYM/download?format=FORMAT route * ontology redirection based on the accept header using /ontologies/acronym/download route * Add redirect assertion in ontologies controller test * Fix content serialization when calling /ontologies/:acronym/:id * create private function for accept header and remove ontology redirection * remove generate_rewrite_rules function * remove redirect assertion in ontologies controller test * change htaccess route to /ontologies/:acronym/htaccess * fix copy internal links in LinkFieldComponent * add raw to copy internal links in identifiers card * return all response and add text/n3 format in content serializer * escape id when redirecting to content_finder * choose the right result from the results of search content * add algorithm to choose the right accept header, not_acceptable if no format valid * add an additional security to the uri redirection to have an exact match * make the check resolvability icon clickable & redirect to the tool page * make the check resolvability extend to accept equivalent formats * move the redirection function from ontologies_controller to uri concern * fix check_resolvability_tool to redirect to the full url not only the path - the problem was because everytime it is redirecting to the uri.path and uri.path does not include the ?format parameter - add the octet-stream accept header in the accepted format for xml * add reference to the url of the original file when format not acceptable * put again the resolvability timeout to 5 secondes * setup content negotiation and redirection tests * remove redirection when request ontology with format - the redirection is removed when request ontology in any format, by making request to the api and forward the result * add ids to the resource format icons and modal * assert the content type for html and json - the xml and csv is returning 500 internal server error from the api, but it's working locally * refactor content_redirection tests - still not completed * add multiple response status for ontology xml and csv format * add test for the content format of the resource * add turtle format based on hasOntologySyntax field * assert success and not_acceptable in turtle format it depends on hasOntologySyntax * add NTriples format for ontologies based on hasOntologySyntax field * test content negotiation for ontology resources * fix redirection url for resource html format * fix ontologies controller test indentation * assert redirection location in resource html format * update the admin user creation in tests possible only by an admin now --------- Co-authored-by: Syphax bouazzouni <[email protected]> * Feature: add Annotator UI tests (#627) * setup annotator page UI tests * check if all the inputs and filters are present in annotator page test * add annotator http requests to test fixtures * test annotator results and count them * test annotator empty illustration * add comments in annotator page tests * use dynamic api in recommender tests * test that we have the exact correct annotations in the annotator test * undo adding ids for elements to run annotator tests * add a default ANNOTATOR_URL value for test config --------- Co-authored-by: Syphax bouazzouni <[email protected]> * Fix: multiple highlighted terms in concepts date view (#657) * Fix multiple highlighted terms in the date view * refactor concepts by date method code * Fix: concept details table layout max-with when long strings (#649) * fix concepts table layout when we put very long strings * fix concepts json button position * use a css class intead of an id for the concepts_json_button * move concepts_json_button css class from concept details file to concepts file * remvoe #concepts_json_link unsued style --------- Co-authored-by: Syphax Bouazzouni <[email protected]> * Feature: Clean no more used gems and code (#658) * remove cube ruby * remove not used gems and add documentation to the Gemfile * remove miniprofiler * remove bpdi resolver and redirect_to_new_api * remove ajax proxy and no more used helpers * remove no more used helpers * handle the case reset_agents in edit submissions error state are already Agents (#663) * Feature: Add issues and requests link to the footer and feedback form (#665) * add issues and requests link to the footer and feedback form * add $GITHUB_ISSUES to sample config file * Fix a typo in bioportal_config_env.rb.sample * fix: upload ontology on errors non returned values and no default values (#625) * move pry gem outside development block in gemfile (#671) * Feature: Add back slices (#598) * Add slices section to home page * Update the design of the slice top notice bar * fix home slice name styles * fix slices error on home page, when there are no slices available * make the annotator support slices * make browse page compatible with slices * update home slices section to include the number of ontologies per slice and the description * make mappings page supports slices * rearrange home page sections to be in this order: slices, ontoportal instances then collaborations * remove unnecessary code in submission filter file * Adjust the slice link to comply with the production URL * update home page slices section style * add a description to the home page slice section * update home page slices section style * update ontoportal instances and support home sections styles * change the button of add new slice to suggest a new group/slice in the home page * update slices descriptive texti in the home page * add a description for ontoportal instances in the home page * move home_ontoportal_tooltip to home helper * add ontoportal links in config file * remove http from slice link to make it work with https * add slice notice to lang local files * remove mappings statistics slices support in the UI cause it's already done in the back * update ontoportal website links to be upper case * fix slices https issue --------- Co-authored-by: Syphax bouazzouni <[email protected]> * fix docker compose to make local env dev work in port 3000 * Fix: submissions properties selector labels and include ontologies properties (#669) * add ontologies properties to the submission properties selector * show submission attributes label instead of the keys in the selector * make slices open in the same tab not in a new tab * put the ontoportal instances directly before the logos instead of a tooltip * Fix: Redirect to the login page when accessing private ontology while being not authenticated (#673) * Feature: Distinguish reused terms in tree view (#650) * distinguish reused properties in the tree view * use preferredNamespaceUri to distinguish reused terms in the tree view if uriRegexPattern is not present * use preferredNamespaceUri to distinguish reused properties in the tree view * distinguish reuses for instances tree * clean terms reuses code * extract is_reused to a separate function in components helper * add concepts reuses to the date view * pass submission directly instead of ontology_uri_pattern * pass direcly the submission instead of passing by a function in terms reuses * Clean terms reuses concern code * add reuses to schemes tree * add reuses to schemes tree when we perform a search * add reuses for collections tree * add reuses to properties tree when we perform a search * add reuses for concepts list view * Clean terms reuses code * extract submission variable form the concept date render helper * remove binding.pry comments left in the code --------- Co-authored-by: Syphax Bouazzouni <[email protected]> * Fix: run production mode (#679) * remove duplicate from gemfile * add port 3000 for production to use it with ontoportal_docker * add commands to run production correctly * Fix: json file extention in export metadata summary page (#683) * hide analytics features if not enabled (#691) * add search placeholder to data table component (#688) * fix browse page contact titleizing (#689) * fix mappings concept link not opening empty pages (#690) * Fix docker compose to make tests work (#695) * Fix: check resolvability tool redirection (#694) * Feature: add rewrite condition in URI redirection rules (#684) * add rewrite condition in the rewrite rules * refactor and clean code of htaccess and nginx redirection rules * Fix: User ontologies custom set updating (#685) * Fix ontologies custom set feature * enhance custom set feature style * remove duplicated action in home controller account, which is the same as show in users controller * clean application helper ontologies selector code * remove unecessary server calls in account page * Remove JQuery code in accounts page * remove repeated server call in custom ontologies features * fix the login flow test after deleting the repeated action related to `/acount` * Feauture: add acronym column in the agents table in the admin page (#704) * Fix: subscribe button issues (#681) * fix clicking on subscribe button while being not logged in * remove non related code to fix subscribe button issues PR * fix subscribe button displays wrong values when using french * replace UnWatch by unwatch * clean subscriptions method code in ontologies controller * Fix the color of the loader component spinning loader * remove duplicated code in subscription button fix * disable cache for subscription button calls * remove invalidate cache for the user calls * Feature: add response time calculation in check resolvability tool (#717) * add response time calculation in check resolvability tool * add other format equivalents to handle most cases of request accept header * move the AVG time to check_resolvability_message instead of appending it * remove the usage of inexistent variable in that block scope * remove comment as the variable name is already clear --------- Co-authored-by: Syphax Bouazzouni <[email protected]> * Feature: add ontology viewOf to the summary page relation network (#716) * Feature: Remove subject values from the project and usage block in summary page (#719) * Feature: Add cookie banner (#702) * add cookies action to show and save cookie state in a session * add link button component helper * add cookie modal view * enhance the style of the cookies banner --------- Co-authored-by: Bilel KIHAL <[email protected]> * Fix: update summary page categories display to show acronym with tooltip (#713) * update summary page categories display to show acronym with tooltip * fix submission flow system tests after changing their display * make show_category return the full domain if not a category * update the show category name to use clickable state if not a category and is a link * fix remove agent usages (#697) * Feature: Enhance agents search input component (#703) * make agents search field component results unlimited to only 4 * make agents cherchable by acronym, affiliations, email and home page * Update the agent search input to display the result in this format Orga name (ACRONYM) – ROR:003vg9w96 and for persons Person Name – ORCID:0000-1524-5487-5487 * chagne display mode value type from string to boolean in search input component * remove agents search logic from UI side and limit it to only name, acronym and identifiers * use the endpoint '/search/agents' for the agents search input component * Fix: saving and cancel button locals text capitalization (#724) * Feature: add qf param in agents search (#727) * Fix: Hide affiliations when agent is organization in agent form (#696) * Hide affiliations when the agent is an organization in the agents form * Change the name of the function affliations? to is_organization? to make it more clear * fix submission flows test after the fix of the PR #713 * fix agent tests after changing the behavior of displaying affiliations --------- Co-authored-by: Syphax <[email protected]> * Feature: Make agent indentifiers field set by default based on agent type (#721) * remove the restriction for certain submission fields to create only organization type or person type agents * make orcid or ror default input based on agent type in agent form * fix disappeared signup form icons * fix nested agents creation * fix agent form not filling saved identifier values * create an agent identifier input helper * disable cookie banner in development and test mode * fix agent tests after enforcing ROR for organizations --------- Co-authored-by: Syphax <[email protected]> * Fix: propertyid param auto added to summary page URL (#723) * Fix propertyId param auto added to summary page URL * remove added PropertyId param to the URL when opening summary page * Fix auto added propertyId to the summary page URL * Fix auto added instanceid to the summary page URL * Fix auto added propertyId to the summary page URL * add back the constraint of making frames loading lazy while env.development * make by default properties section displays the first property * make by default instances section displays the first instance * change the name of the function instances_tree_first_id by search_first_instance_id * add a clarification comment in search_first_instance_id method * move get_property function to properties controller --------- Co-authored-by: Syphax <[email protected]> * fix losing context when changing language in concepts page * fix concept not added to browser URL param issue * refrech the whole page when we change concepts language * fix not saving the current url context when changing the language * Revert "Merge remote-tracking branch 'origin/fix/change-language-lost-context' into fix/change-language-lost-context" This reverts commit c7b6d08, reversing changes made to cb3b7ba. * update turbo frame controller to handle ontology viewer special case --------- Co-authored-by: SirineMhedhbi <[email protected]> Co-authored-by: Syphax bouazzouni <[email protected]> Co-authored-by: Imad Bourouche <[email protected]>
* add domain, range and properties to the property show view * fix the selection of the property using params[:propertyid] if given
Fix: Release 2.9.2 hotfixes
* create taxonomy (groups&categories) route, view, controller * add groupes and categories tabs sections * do the layout of the groupes section in taxonomy page * extract taxonomy card to a helper * add slice icon for the groupes associated with a slice in the portal * display categories in taxonomy page * put taxonomy page texts in local lang files * use models methods instead of get http calls in taxonomy controller * create a viewcomponent for taxonomy card instead of a helper * fix name of groups section view (from groupes) * add the possibility to add parent category in the admin page * display categories children in categories page * make slice icon clickable in groupes cards * make ontologies clickable in groups and categories cards * add /groups and /categories routes * change browser link when user change section in taxonomy page * put parent category in local lang files * fix some typos in groups and categories page * show ontology names in tooltip in groups&categories page * add link to groups and categories in the topnav * add link to taxonomy page in browse page * limite description text size in taxonomy card component * create limited container component and use it in taxonomy card component to limit ontologies chips height * update taxonomy page description * extract categories_for_select to a resusable helper * clean taxonomy controller routes * move browse_taxonomy_tooltip from application helper to ontologies helper * extract categories select to a reusable helper * clean taxonomy partials * fix limited container component hight mesuring * make the tabs overwriting apply only for the groups categories page * fix the info tooltip text of the community dropdown --------- Co-authored-by: Syphax <[email protected]>
Fix: properties domain and range links opening content missing page and cookies banner reappearing each day
Merge to master: Release 2.9.2
* simplify the header component to use content instead of a new section * update dropdown component to a custom title section instead of text * update browse page to use Dropdown component not bootsrap one * add color option to square badge component * add text and bg colors options to ontology browse card component * add federation helper code and config sample * add portals filters in the browse page * use federation helpers to get federation ontologies information * remove the filter using index code from submission filter as no used * refactor the filter_using_data function to be faster by using an hash * update the browse analytics cache to change depending on portals * add categories and groups ids on hover to know its origin when federated * use the last part of ids for browse counts independently of its origin * remove binding.pry from final federation code * add an error message if one of the external portal is down * remove $FEDERATED_PORTALS and use existent $PORTALS_INSTANCES variable * handle the merging of the same ontology from different portals * fix groups and categories selection at browse page init
* add portal configuration action and view to home controller * create portal_config_tooltip helper and use in homepage portals section * enhance portal config home section style --------- Co-authored-by: Bilel KIHAL <[email protected]>
…ookie banner (#760) * Add language-specific anchors to footer section links * Add language-specific anchors to the cookie banner * Refactor language-specific anchors to use I18n default option * Remove anchors from bioportal_config_env.rb.sample; now handled by footer view
…, Instances, Schemes, and Collections (#754) * limite taxonomy card ontologies chips number and add a see all button * Properties layout harmonization * Instances layout harmonization * fix: resolve issues related to properties raised in code review * fix: resolve issues related to instances raised in code review * adding subtab "Details" and API cotextual button to `Schemes` * adding subtab "Details" and API cotextual button to `Collections` * Using unless instead of if in sections controllers * Adding new section tab component and using it in Properties, Instances, Schemes and Collections * display first scheme if none are selected * move the created tabs_section component to rails helpers * fix schemes and collections shows not selecting the right object * remove details partials moving the content directly to the show files * remove unnecessary call in the properties show to find the ontology * use the correct partial in the schemes controller show action * put the tab item helper in the component helpers as generic * use the correct collection partial in the show action * remove unnecessary local in the instances partial * clean instance show partial code * remove unnecessary locals in the properties partial call * remove unnecessary locals in the collections show partial call * remove unnecessary locals in the schemes show partial call * Add presence check (not nil and not empty) for ontology details component before rendering --------- Co-authored-by: Syphax bouazzouni <[email protected]> Co-authored-by: Bilel KIHAL <[email protected]>
…te-login-redirection Fix: User Account Page, Infinite redirect loop to login page
…e-countries Feature: Support countries as languages
* update categories selector in admin page to allow multiple parentCategories * handle category multiple parents in category page * add null safety in nest categories children function
* ensure that the custom ontology viewer context fix is only applied to it * handle collections sort if all languages mode raising an exception
* simplify the header component to use content instead of a new section * update dropdown component to a custom title section instead of text * update browse page to use Dropdown component not bootsrap one * add color option to square badge component * add text and bg colors options to ontology browse card component * add federation helper code and config sample * add portals filters in the browse page * use federation helpers to get federation ontologies information * remove the filter using index code from submission filter as no used * refactor the filter_using_data function to be faster by using an hash * update the browse analytics cache to change depending on portals * add categories and groups ids on hover to know its origin when federated * use the last part of ids for browse counts independently of its origin * remove binding.pry from final federation code * add an error message if one of the external portal is down * display federated results in search page * display federated search results in different colors * add portals param in federated search * add federation checks in search page * merge federated search results * show portals names in federated search result chips in the form 'AgroPortal' instead of 'agroportal' * sort federated search results by string similarity * fix merge development to federated search issues * clean search result component * internationalize: results from other portals in search and browse page * fix performance issue in federated search * merge results using class id and ontology acronym * extract federation enabled into a helper in federated search * refactor search result elem function * add realtime benchmark for search federated search * add portal names and colors in top of federated search results * make sort by string similarity not case sensitive * remove duplicated federation configuration * extract portal button in home page to federation helper, fix the style of it and make it clickable * fix icons colors in federation * display a message in the federated search results when a portal is not responding * disable input chips in federated search page for the portals that are not responding * show tooltip for disabled input chips in the federated search * clean search controller federation code * update ontologies api ruby client to the latest version of federated search * fix federated browse icons colors * add tooltip for portal button in federated search * open external ontologies links in new tab in federated browse * use portal button helper in federated browse * cache federation status call * update chip helpers to support disabled state * use turbo frame for federation input chips, and use federation portals status to disable non working portals * add skelton loading animation for federation input chips * cache federation input chips separately * use cached federation input chips in browse page * fix browse page federation inputs section title style * initialize federation portals input chips in the home page (asynch in the background) * clean federated search aggregator code * move chip skelton to components helper * internationalize portal is not responding message * clean federation portal status cache method * clean federation stimulus controller code * display federated browse errors as warning instead of danger (orange instead of red) * remove related code to fedrated portals status to put it in another PR * use the key "collection" instead of "results" in federated search result hash to maintain the endpoint expected schema * Fix issue when enabling federation and ontologies selector * rename the federation color setter stimulus controller * extract federation errors helpers and a fix a typo in a function name * clean search aggregator by extracting some federation helpers * use again the development branch of the api client * fix some imports and functions calls after the refactor * extract and create federated portal button component * put again custom api documentation line * remove no more used data controller calls * clean the search result component federated code --------- Co-authored-by: Syphax bouazzouni <[email protected]>
* cache federation status call * update chip helpers to support disabled state * use turbo frame for federation input chips, and use federation portals status to disable non working portals * add skelton loading animation for federation input chips * cache federation input chips separately * use cached federation input chips in browse page * fix browse page federation inputs section title style * initialize federation portals input chips in the home page (asynch in the background) * clean federated search aggregator code * move chip skelton to components helper * internationalize portal is not responding message * clean federation portal status cache method * clean federation stimulus controller code * display federated browse errors as warning instead of danger (orange instead of red) * use federation portal status in home page portals configuration * fix issue in federation portal status method * clean portal_config_tooltip method to make it more readable * consider the portal as down if the api of it is not present in the config file * put federation portal status vue in a helper, and remove the html file of it * internationalize portals status message * extract federation_input_chips to a helper * put init portals status in home page logic in a helper for clarity * change home/federation_portals_status root to status/:portal_name * use dig in federation_portal_status to ensure to not raise an exception * move init portal status helper to federation file and fix class name * move federation helpers from application helper to federation file and fix variables calls * add loading state to the chips component and use it in federation status * rename federation chip component helper name to prevent conflicts --------- Co-authored-by: Syphax bouazzouni <[email protected]>
…hanged (#779) * sort by name when we do federated browse * extract categories and groups inputs sections into a turbo frame * use switch input helper in the browse page for more clarity * create dropdown component helper and add small argument to loader helper * use current_user_admin? helper instead of session[:user]&.admin? * move some of the browse page code to helpers * fix the bug of mixing the section filters because this.element was the container not the filters section blocks * update the categories section in browse page if request_portal changed --------- Co-authored-by: Syphax <[email protected]>
* add text for api json button in search page, and show it only when the search is performed * count federated search results count by portal * show separate portals federated search result counts * show separate federated browse ontologies counts for each portal * Fix color issue in browse page portal name button * fix federated browse counts function to handle all cases * limit search page results count sentence width * fix api json button non clickable in search page * Fix external ontology icon when the ontology is not external in the browse page * display ontology sources buttons in browse page for internal ontologies that are present in other portals * use helpers for re-used ui components in the search UI page * extract same helper for the error message alert UI component * harmonize federation result text code * fix text_with_icon helper style * remove no more used :from local text key * complete match_in local text * move urls related helpers from application_helper to urls_helpers file * update search aggregator and result component to save ontology id * extract common logic to count ontology id from search and browse results * clean url helpers usages --------- Co-authored-by: Syphax <[email protected]>
* method to get the canonical portal for an ontology using pullLocation * display federated ontologies in browse page based on the canonical portal * clean canonical portal function in federation helper * extract canonical portal ontology choice in a function for clarity * display search page results based on the canonical portal of the ontology * move federation canonical to federation helper * clean swap portal attributes function in federation helper * fix and clean apply canonical portal function * extract count portals into a separate function from external_canonical_ontology_portal function + apply_canonical_portal function * put again search canonical logic the search_aggregator file and refactor the code * do the search canonical logic only if enabled * fix rest_hostname raising an exception that REST_URI does not exist --------- Co-authored-by: Syphax bouazzouni <[email protected]>
* create metrics helper module and implement portal_metrics that handle slices also * update home controller and home index to use the portal_metrics helper * add mappings sliced count * add projects sliced count * use the slice name in figures section title if enabled * fix mappings metrics count when not sliced to includes interportal and external mappings
* fix summary page scroll up auto multiple times * clean center tree view code and use it for: 'classes', 'properties', 'schemes', 'collections', 'instances' * revert adding useVisibility, and extract tree_view_pages to a constant
* add enable/disable federation * hide federation inputs in browse page when federation is disabled * hide federation inputs in search page when federation is disabled * fix federation enabled function name in ontologies controller * put @federation_enabled variable in the right place in search controller index * rename federation_portals_enabled? to federated_request? * remove the usage of "@federation_enabled" to use directly the helper * fix a bug of the url of federation status, to add "/" to sure to always go to the correct route --------- Co-authored-by: Syphax <[email protected]>
* fix jump to infinit loading * search result as an object instead of hash in search controller
* include views in ontologies selector * refactored onts_for_select to have the option to include views and by default no --------- Co-authored-by: Syphax <[email protected]>
* fix the issue in the projects page when the ontologies are private * fix ontologies selector name in projects from * pass the correct project ontologies value in project ontologies selector * pass an empty array if used ontologies of a group is nil
…ure main_language_label is defined in collections helper (#793)
…ews in the list (#791) * fix ontologies selector weird results sentence * show [view] beside ontology views in ontologies selector
… any language remaining over the not tagged (#795) * update select_language_label helper to select f no english found any language remaining over the not tagged * fix tests by fixing a dependency change * fix login system tests after securing the user delete action in the API
* fix mappings table style * hide relations column when it's completely empty * use icons and Abbreviations types and sources * hide actions column if no mapping is of type REST * update create new mapping button style * remove concept mapping table padding * remove relation column and remove Action title * make the column width for the mapping to and ontology larger * move some mappings helper to the mapping controller as used only there * move the logic from the mapping table view to helpers * fix link text component icon size * change mappings action icons colors to primary color * pass button component in create new mapping instead of using only the css of it * internationalize create new mapping button text * internationalize mapping types description * fix interportal mapping issue when the interportal_hash is empty * limit mapping type tooltip by 300px width --------- Co-authored-by: Syphax <[email protected]>
Merge to master: Release 3.0.0 - OntoPortal federation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - unless types.empty? | ||
| - t.add_row({ th: t('instances.type') }) do |r| | ||
| - r.td do | ||
| = types.map { |cls| link_to_class(@ontology.acronym, cls) }.join(', ').html_safe |
Check notice
Code scanning / Brakeman
Unescaped parameter value. Note
syphax-bouazzouni
force-pushed
the
feature/biodivportal/align-to-agroportal-3.0
branch
from
0da46e4 to
14d248a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in:
Backend changes