Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for both NVIDIA and AMD GPUs #66

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

Add support for both NVIDIA and AMD GPUs #66

wants to merge 54 commits into from

Conversation

sfiligoi
Copy link
Collaborator

@sfiligoi sfiligoi commented Feb 3, 2025

The NV and AMD GPU code now each have their own shared library.
The two can co-exist, and the code will use whichever GPU is available.

Note: The GPU code can be compiled independently of the CPU code, and installed separately, too.
The default behavior is to try to use the GPU libraries, if available, but gracefully proceed with CPU-only execution if such library have not been installed.

sfiligoi and others added 30 commits January 23, 2025 14:38
@sfiligoi
Add su::biom::load_n_samples and use in su.cpp
3c1b044
@sfiligoi
Remove unnecessary header includes
6838090
@sfiligoi
Expose the partial functions in libssu
1efade6
@sfiligoi
Make libssu trully thread-safe
897ce3e
@sfiligoi
Make ssu and faithpd use the shared library
817b7d7
@sfiligoi
Add missing header include
518c319
@sfiligoi
Use explicit object list in rapi_test dependency
b45d9dc
@sfiligoi
Export dl_read_partial and properly clean between rebuilds
1f65ef6
@sfiligoi
Use shared library in test_api. Deprecate merge_partial, since not us…
ef32989 
…e anywhere anymore
@sfiligoi
test_ska does not use the unifrac object files
f9a2aaf
@sfiligoi
Create an intermediate archive file to avoid dependencies for functio…
2d106e4 
…ns we do not use
@sfiligoi
Add API-based unifrac tests in test_su
a1a2c5b
@sfiligoi
Add API-based faithpd tests in test_su
b45a9c7
@sfiligoi
Add test_su_api to exercise the optimiza code paths (test_su exercize…
ddceeee 
… the cpu-only internals)
@sfiligoi
Handle NOGPU at top-level Makefile, so nv not required
e53236e
@sfiligoi
Add support for parallel make
ba82d84
@sfiligoi
Add clean_install make option
267d158
@sfiligoi
Fix test_su_api checks
7c9c6ac
@sfiligoi
Add cpu-only builds
a74e67c
@sfiligoi
Explicitly create all variants of unifrac_task_noclass
13f7026
@sfiligoi
Use internally a C API layer for the accelerated code
b1b1f69
@sfiligoi
Fix Makefile for acc
fc1c73d
@sfiligoi
Explicity use h5c++ for everything but acc code. Use CXX for acc code
df97366
@sfiligoi
Modularize ld loading in src/ssu_ld.c
aac7d13
@sfiligoi
Move handling of UNIFRAC_CPU_INFO into ssu_ld.c
bec652e
@sfiligoi
Put gpu code into its own shared library. No need for pgi h5c++ wrapp…
042ad3f 
…er anymore
@sfiligoi
Put gpu code into its own shared library. No need for pgi h5c++ wrapp…
5a0ce0c 
…er anymore - Fix typo
@sfiligoi
Add symlink unifrac_task.cpp to make R happy
0fab9aa
@sfiligoi
Do not check for /proc/driver/nvidia/gpus, not needed
c65289b
@sfiligoi
Make loading of GPU shared library optional during initial test
2ff25ef
@sfiligoi sfiligoi marked this pull request as draft February 3, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfiligoi