Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 956 #962

Merged
merged 3 commits into from
May 7, 2024
Merged

Issue 956 #962

merged 3 commits into from
May 7, 2024

Conversation

wasade
Copy link
Member

@wasade wasade commented May 2, 2024

Fixes #956
Fixes #955

@qiyunzhu, would you be able to review?

The underlying issue is below:

# 2.0rc1
>>> for v in a:
...   print("%r" % v)
... 
np.int64(0)
np.int64(1)
np.int64(2)
np.int64(3)
np.int64(4)
np.int64(5)
np.int64(6)
np.int64(7)
np.int64(8)
np.int64(9)

vs.

# 1.26.1
>>> for v in a:
...   print("%r" % v)
... 
0
1
2
3
4
5
6
7
8
9

Copy link
Contributor

@qiyunzhu qiyunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@wasade
Copy link
Member Author

wasade commented May 2, 2024

Thanks!

@wasade wasade merged commit e8e6ed6 into biocore:master May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumPy compatibility issue (further) NumPy 2.0 compatibility issue
2 participants