Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement subsample_without_replacement using C++17 std::sample #934

Closed
wants to merge 3 commits into from
Closed

Implement subsample_without_replacement using C++17 std::sample #934

wants to merge 3 commits into from

Conversation

sfiligoi
Copy link
Collaborator

No description provided.

@sfiligoi
Copy link
Collaborator Author

CC @wasade

@sfiligoi
Copy link
Collaborator Author

This version uses drastically less memory, as it does not expand the buffer using np.repeat.
Should be cheaper compute wise, too.

@sfiligoi
Copy link
Collaborator Author

sfiligoi commented Jun 13, 2023 •
edited
Loading

Alternative version available in #935 , obsoleting this one.

@sfiligoi sfiligoi closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfiligoi