Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk: UCSC updates #50393

Merged
merged 4,265 commits into from
Aug 28, 2024
Merged

Bulk: UCSC updates #50393

merged 4,265 commits into from
Aug 28, 2024

Conversation

aliciaaevans
Copy link
Contributor

Updates from running the updated ucsc scripts (thanks @martin-g ): #50325

Also:

  • Merged in changes from ci: Fix platform script echo #50389 and ucsc-bigwigsummary: update macOS build #50368 for OSX (Thanks @mencian) and bumped build number
  • Updates to the script to fix a few formatting issues (curly brackets in the template, whitespace)
  • Due to the issue with the additional platforms script, had to skip flye and sorted_nearest for osx-arm64 with build failure files. (They never actually built in their respective PRs.) Those need to be fixed in new PRs.

Note: PR checks will not succeed for this. Everything is already built and uploaded to the channel. I'll merge after approval.

aliciaaevans and others added 30 commits June 12, 2024 09:45
@aliciaaevans
Copy link
Contributor Author

oops, got to remove those extra files

@aliciaaevans aliciaaevans added the please review & merge set to ask for merge label Aug 28, 2024
@aliciaaevans aliciaaevans merged commit a229844 into master Aug 28, 2024
5 of 7 checks passed

extra:
additional-platforms:
- linux-aarch64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliciaaevans Did this recipe fail to build on linux-aarch64 ?
It was building fine before. I will re-test it in a new PR!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the commit where I removed all the build failure files in favor of just removing the additional platform, if you want to look at the errors: 1ad838e but these all had a similar error. Maybe something changed in one of the dependencies since your original PR?

There are also a couple linux-64 with that same undefined reference to knet_init_alt error. https://github.com/bioconda/bioconda-recipes/blob/bulk/recipes/ucsc-hubcheck/build_failure.linux-64.yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried by restoring some of the changes in include.patch and meta.yaml at #50407 but it still fails the same way....


extra:
additional-platforms:
- linux-aarch64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@martin-g
Copy link
Contributor

Many thanks for finishing this task, @aliciaaevans !

I will check why the following recipes failed to build now on aarch64:

ucsc-genepredcheck
ucsc-genepredtobed
ucsc-genepredtobiggenepred
ucsc-genepredtogtf
ucsc-gff3togenepred
ucsc-gtftogenepred
ucsc-hggcpercent
ucsc-liftover

They were fine before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants