add masking chains by CDRs, fix naming of runction chain masking #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norsage
reviewed
Dec 8, 2023
training/model_utils.py
Outdated
| @@ -36,13 +39,41 @@ def get_index_of_masks(len_seq:int,max_parts:int,max_length:int)->list[int]: | |||
| if s>=t[0] and s<=t[1] or e>=t[0] and e<=t[1]: | |||
| f=True | |||
| break | |||
| if not f: | |||
| if not f and (s==0 or not mask[s-1]) and (e==len_seq-1 or not mask[e+1]): | |||
There was a problem hiding this comment.
Очень сложно понять, что в этой функции происходит, можно однобуквенные переменные заменить на что-то более содержательное? под сложные условия тоже хорошо заводить булевы переменные, если это позволяет лучше понять логику
norsage
reviewed
Dec 8, 2023
training/model_utils.py
Outdated
| tuples.append((s,e)) | ||
| for i in range(s,e+1): | ||
| mask[i]=1 | ||
| return mask | ||
|
|
||
| def featurize(batch, device,max_parts=6,max_length=6): | ||
| def get_mask_cdrs_one_chain(chain,max_parts,max_length,indexes_of_cdrs): |
There was a problem hiding this comment.
Если в этой функции цель - получить бинарную маску, где нули стоят на месте нужного региона, то можно намного проще: создать массив из нулей, получить положение нужного региона, заменить на месте 0 на 1 через оператор среза, без циклов.
|
Пожелание по всему коду: пройтись flake8, проставить аннотации типов, избавиться от однобуквенных переменных, если они живут дольше, чем в одной строчке. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.