Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qualified path for Result::Ok in bincode_derive #757

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

nhaef
Copy link
Contributor

@nhaef nhaef commented Mar 10, 2025

fixes #756 by using a qualified path for core::result::Result::Ok.

@VictorKoenders
Copy link
Contributor

Can you add a test for this too? Something like:

fn Ok(){}

#[derive(Encode, Decode)]
struct A { a: u32 }

#[derive(Encode, Decode)]
enum B { A, B }

@ZoeyR ZoeyR merged commit bd99729 into bincode-org:trunk Mar 10, 2025
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bincode_derive's Encode and Decode proc macros fail if module declares use anyhow::Ok
3 participants