Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllOrder Method to query orders #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maikonweber
Copy link

Pull Request Description

Summary

This pull request adds a new method allOrders to the Trade class in order to retrieve all orders for a specific symbol using the Binance API.

Changes

  • Added a new method allOrders to the Trade class.
  • The allOrders method makes a GET request to /api/v3/allOrders endpoint.
  • The method takes a symbol parameter and optional options parameter to specify additional query parameters.
  • The method returns the data received from the Binance API for all orders.

Usage Example

// Assuming you have an instance of the Trade class
const tradeInstance = new Trade();

// Specify the symbol and options (if needed)
const symbol = 'BNBUSDT';
const options = {
  // Add any additional options if required
};

// Call the allOrders method
try {
  const allOrders = await tradeInstance.allOrders(symbol, options);
  console.log('All orders:', allOrders);
} catch (error) {
  console.error('Error retrieving all orders:', error);
}

@alplabin
Copy link
Contributor

alplabin commented Apr 1, 2024

@maikonweber The endpoint you are adding already exists in the connector: allOrders

Could you please clarify if there is any issue with the existing implementation that prompted the addition of this endpoint?

@alplabin alplabin added the question Further information is requested label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants