解决一个if语句的逻辑错误和一个段错误 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'if' statement for checking whether the command-line arguments are empty, an extra '!' was added, leading to a logic error.
When the filename in the command-line arguments of simple_quic_server is a relative path, the fopen system call fails, leading to the failure of ProofSource initialization and subsequently causing a segmentation fault due to a null pointer reference. Resolve: The FilePath class adds a method to check whether the file name is an absolute path. Simple_quic_server checks if the file is an absolute path when opening the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25
IF语句逻辑错误
simple_quic_server在判断命令行参数是否为空的if语句中，错误地添加
!导致逻辑错误。段错误
当simple_quic_server的命令行参数中的文件名为相对路径时，fopen函数调用失败，导致ProofSource初始化失败，进一步导致段错误。