[BUG] Fix passing mode_array in injection-waveform-arguments

[lorenzopompili00]

When doing injections with bilby_pipe, passing a mode_array for the injected waveform via injection-waveform-arguments does not currently work, because of a missing conversion from string to int. See issue for details. Doing this conversion in bilby_pipe breaks some unit tests (see MR), so I have implemented the conversion in bilby only when mode_array is called.

Note that pyseobnr currently wants mode_array to be a list of tuples, but I don't think a standard convention has been decided for future models in gwsignal.

I have tested this by adding

injection-waveform-arguments={'mode_array':[[2,2],[2,-2]]}

to the example bbh_injection.ini, as well as for

injection-waveform-arguments={'mode_array':[[2,2],[2,1]]}
injection-waveform-approximant="SEOBNRv5PHM"
injection-frequency-domain-source-model=gwsignal_binary_black_hole

(I also had to include the fix for #41).

[ColmTalbot]

I think we should wrap these changes in a try/except like here so that we get an informative error if/when this fails for any reason. We can also have a more specific message here as it is a more specific case.

[mj-will]

Looks good to me, just had one comment about making the error message more informative.

[mj-will]

LGTM, assuming the CI passes.

[ColmTalbot]

I'm happy with this as is.

[mj-will]

@ColmTalbot I think it's worth having a second look at this following the change Lorenzo made based on the discussion above.

[ColmTalbot]

This looks pretty slick now, thanks @lorenzopompili00!

[ColmTalbot]

It looks like there is a conflict that stops me from rebasing, can you update Lorenzo? and then we'll merge.

[lorenzopompili00]

Just updated @ColmTalbot !