Fixed timestamp issue #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Strava exceptions
Fixed nil pointer reference
Fixes part 69
User refreshing was bugged
MeurillonGuillaume
requested review from
xivk,
Driesvanransbeeck,
antoinerichez and
BertSchoovaerts
antoinerichez
approved these changes
Sep 29, 2020
|
hey @MeurillonGuillaume thanks so much for this! Looks good! How much testing did you do? I want to guesstimate the risk to updating this... I don't have a lot of spare debugging time today and the launch is tomorrow ;-) |
xivk
approved these changes
Sep 30, 2020
|
Also looking at the code am I correct in assuming this also fixes #20 ? |
|
Hey @xivk! This does not yet fix #20, the tiny fix for that is still in this branch, or this commit. I did not really test this at all 😇 Mostly since I don't have the local deployments anymore. Also since the change is very minor, it splits an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
As seen in #19
Edit: Excuse the mess, seems like develop wasn't up to date with master 😅