Command, allow to search User by Email #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nek-
suggested changes
May 29, 2019
| if ($input->hasOption('role') | ||
| if ($input->hasOption('email') | ||
| && null !== $input->getOption('email')) | ||
| { |
There was a problem hiding this comment.
wow, how did it happen like that? Please fix indentation.
| if (!$find) { | ||
| $output->writeln(sprintf('<error>User with role "%s" doesn\'t exist.<error>', $input->getOption('role'))); | ||
| && !in_array($input->getOption('role'), $user->getRoles())) | ||
| { |
| && !in_array($input->getOption('role'), $user->getRoles())) | ||
| { | ||
| $user = $this->findOneByRole($input, $output, $users); | ||
| } |
There was a problem hiding this comment.
If we specify email and role, role will be ignored. This is due to refactoring in splitted methods. You probably should consider to add an error message or drop this refactoring and use a single (fat, I admit) condition.
There was a problem hiding this comment.
I'm assuming that if you use the 'email' flag you must know which user you want and therefore you need to know which role this user have
|
@megan3ss ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option for the "biig:jwt:generate"
This option allow to search an User by its Email