Merge pull request #74 from biig-io/fix/profiler-issues

Fix #73
biig-io · Mar 13, 2020 · 9da4dd8 · 9da4dd8
2 parents 2889a3a + 06470ac
commit 9da4dd8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/Tests/Debug/TraceableDomainEventDispatcherTest.php b/Tests/Debug/TraceableDomainEventDispatcherTest.php
@@ -73,6 +73,17 @@ public function testItAddsPostPersistDomainRuleInterface()
         $domainEventDispatcher->addPostPersistDomainRuleInterface($rule->reveal())->shouldBeCalled();
         $tdispatcher->addPostPersistDomainRuleInterface($rule->reveal());
     }
+
+    public function testTraceableNeverRegisterNullEvents()
+    {
+        $tdispatcher = new TraceableDomainEventDispatcher(new DomainEventDispatcher());
+        $tdispatcher->dispatch(new DomainEvent(), 'foo');
+        $tdispatcher->dispatch(new DomainEvent());
+
+        foreach ($tdispatcher->getEventsFired() as $firedEvents) {
+            $this->assertNotNull($firedEvents);
+        }
+    }
 }
 
 class FakeCalleable2 {

diff --git a/src/Debug/TraceableDomainEventDispatcher.php b/src/Debug/TraceableDomainEventDispatcher.php
@@ -81,6 +81,9 @@ public function persistModel(ModelInterface $model)
      */
     public function dispatch($event, string $eventName = null)
     {
+        if ($eventName === null) {
+            $eventName = get_class($event);
+        }
         $this->eventsFired[] = $eventName;
 
         return parent::dispatch($event, $eventName);

diff --git a/src/Integration/Symfony/Resources/views/Collector/domain_event_template.html.twig b/src/Integration/Symfony/Resources/views/Collector/domain_event_template.html.twig
@@ -86,12 +86,12 @@
     <table>
         <thead>
         <tr>
-            <th>Event</th>
+            <th>Priority</th>
             <th>Listener</th>
         </tr>
         </thead>
 
-        {% set previous_event = (listeners|first).event %}
+        {% set previous_event = null %}
         {% for listener in listeners %}
             {% if loop.first or listener.event != previous_event %}
                 {% if not loop.first %}