Merge pull request #68 from biig-io/fix/denormalizer-service-definiti…

…on-v1 V1 - Don't register Domain Denormalizer if Symfony serializer isn't installed
biig-io · Nov 15, 2019 · 6154f36 · 6154f36
2 parents 99f28d4 + 8ac5e9a
commit 6154f36
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/Tests/Symfony/DependencyInjection/CompilerPass/EnableDomainDenormalizerCompilerPassTest.php b/Tests/Symfony/DependencyInjection/CompilerPass/EnableDomainDenormalizerCompilerPassTest.php
@@ -28,17 +28,18 @@ public function testItAddsDefinitionServiceForApiPlatformDomainDenormalizer()
     public function testItAddsDefinitionServiceForDomainDenormalizer()
     {
         $compilerPass = new EnableDomainDenormalizerCompilerPass();
-        $compilerPass->process($this->getContainerMock());
+        $compilerPass->process($this->getContainerMock(false, true));
     }
 
-    private function getContainerMock($apiPlatform = false)
+    private function getContainerMock($apiPlatform = false, $symfonySerializer = false)
     {
         $container = $this->prophesize(ContainerBuilder::class);
         $definition = $this->prophesize(Definition::class);
 
         $container->hasDefinition('api_platform.jsonld.normalizer.item')->willReturn($apiPlatform ? $apiPlatform : []);
         $container->hasDefinition('api_platform.serializer.normalizer.item')->willReturn($apiPlatform ? $apiPlatform : []);
         $container->hasDefinition('api_platform.hal.normalizer.item')->willReturn($apiPlatform ? $apiPlatform : []);
+        $container->hasDefinition('serializer.normalizer.object')->willReturn($symfonySerializer ? $symfonySerializer : []);
 
         if ($apiPlatform) {
             //api_platform.jsonld.normalizer.item
@@ -64,11 +65,13 @@ private function getContainerMock($apiPlatform = false)
 
         }
 
-        $definition->setDecoratedService(Argument::type('string'))->willReturn($definition)->shouldBeCalled();
-        $definition->addArgument(Argument::type(Reference::class))->willReturn($definition)->shouldBeCalled();
-        $definition->addArgument(new Reference('biig_domain.dispatcher'))->willReturn($definition)->shouldBeCalled();
-        $definition->setPublic(false)->willReturn($definition)->shouldBeCalled();
-        $container->register('biig.domain_denormalizer', DomainDenormalizer::class)->willReturn($definition);
+        if ($symfonySerializer) {
+            $definition->setDecoratedService(Argument::type('string'))->willReturn($definition)->shouldBeCalled();
+            $definition->addArgument(Argument::type(Reference::class))->willReturn($definition)->shouldBeCalled();
+            $definition->addArgument(new Reference('biig_domain.dispatcher'))->willReturn($definition)->shouldBeCalled();
+            $definition->setPublic(false)->willReturn($definition)->shouldBeCalled();
+            $container->register('biig.domain_denormalizer', DomainDenormalizer::class)->willReturn($definition);
+        }
 
         return $container->reveal();
     }

diff --git a/...gration/Symfony/DependencyInjection/CompilerPass/EnableDomainDenormalizerCompilerPass.php b/...gration/Symfony/DependencyInjection/CompilerPass/EnableDomainDenormalizerCompilerPass.php
@@ -39,11 +39,13 @@ public function process(ContainerBuilder $container)
             ;
         }
 
-        $container->register($serviceId, DomainDenormalizer::class)
-            ->setDecoratedService('serializer.normalizer.object')
-            ->addArgument(new Reference($serviceId . '.inner'))
-            ->addArgument(new Reference('biig_domain.dispatcher'))
-            ->setPublic(false)
-        ;
+        if ($container->hasDefinition('serializer.normalizer.object')) {
+            $container->register($serviceId, DomainDenormalizer::class)
+                ->setDecoratedService('serializer.normalizer.object')
+                ->addArgument(new Reference($serviceId . '.inner'))
+                ->addArgument(new Reference('biig_domain.dispatcher'))
+                ->setPublic(false)
+            ;
+        }
     }
 }