cleanup, add todos

samplesheets/rendering.py

@@ -394,12 +394,9 @@ def _add_annotation(self, ann, header, header_type, obj):
         :param obj: GenericMaterial or Process object the annotation belongs to
         """
         unit = None
-        # Special case: Comments as parsed in SODAR v0.5.2 (see #629)
+        # Special case: Comments as string or list
         # TODO: TBD: Should these be added in this function at all?
-        if isinstance(ann, str):
-            val = ann
-        # Comment as a list
-        elif isinstance(ann, list):
+        if isinstance(ann, (str, list)):
             val = ann
         # Ontology reference(s) (altamISA v0.1+, SODAR v0.5.2+)
         elif isinstance(ann['value'], dict) or (

samplesheets/vueapp/src/components/editors/DataCellEditor.vue

@@ -158,6 +158,7 @@ export default Vue.extend({
           return false
         }
       } else if (this.editValue !== '') {
+        // TODO: Enable validation of listed values separately
         // Test range
         if (['integer', 'double'].includes(this.editConfig.format) &&
             'range' in this.editConfig &&
@@ -350,6 +351,7 @@ export default Vue.extend({
     if (!this.destroyCalled) {
       this.destroyCalled = true // HACK for issue #869
       // Convert to list value if applicable
+      // TODO: Allow for integer, double and unit-having fields
       if (this.editValue.includes(';') && (
         this.isValueArray || (
           !['integer', 'double'].includes(this.editConfig.format) &&