-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unattended config setup for iRODS #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comments. I don't think we can get rid of the b64 hack.
@@ -23,52 +51,41 @@ RUN yum install -y epel-release && \ | |||
|
|||
# Install dependency packages | |||
RUN yum install -y \ | |||
postgresql12 \ | |||
sudo | |||
postgresql11 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 11 and not 12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because sodar-docker-compose uses 11 for postgres. Just went with the same version to maintain consistency. Can update both of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'd say we should start out with the latest stable version.
https://www.postgresql.org/support/versioning/
VarFish uses 12. But maybe for SODAR/iRODS we should go for 14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also related to this: bihealth/sodar-docker-compose#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some killer features iRODS specifically needs from the later Postgres versions?
if [ -f /irods_python-re_installer.py ]; then | ||
./irods_python-re_installer.py | ||
fi | ||
|
||
touch /etc/irods/.provisioned | ||
fi | ||
|
||
find /var/lib/irods -not -path '/var/lib/irods/Vault*' -exec chown -c irods:irods {} \; | ||
chown -cR irods:irods /etc/irods | ||
find /var/lib/irods -not -path '/var/lib/irods/Vault*' -exec chown -c $IRODS_SERVICE_ACCOUNT_GROUP:$IRODS_SERVICE_ACCOUNT_USER {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move the vault out to a bind mount to /data
? I have earlier had problems with irods doing a chown -R
on the /var/lib/irods
and this then going into the full ceph file system...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a TODO for this.
} | ||
} | ||
|
||
{# XXX #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this stay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not! :)
Note to self, check this for the b64encode workaround: https://pypi.org/project/jinja2-base64-filters/ |
Meh, looks like this isn't compatible with j2cli. Keeping the existing hack for now. It works and can be nicened up later if needed. |
Working on an unattended config setup for iRODS.
TODO
Fix "error encountered in graceful shutdown" error from iRODS at the end of iCAT setup(see Graceful shutdown error in setup_irods.py #2)Find replacement for uglyb64encode
hackirods_python-re_installer.py
works, update as neededIRODS_CATALOG_PROVIDER_HOST