Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle missing section headers at EOF #105

Closed
wants to merge 1 commit into from
Closed

fix: Handle missing section headers at EOF #105

wants to merge 1 commit into from

Conversation

sellth
Copy link
Collaborator

@sellth sellth commented Nov 2, 2023

_read_next_line returns None at EOF which the various _read functions need to handle to pass on useful information to the user.

fixes #104

@sellth sellth requested a review from mkuhring November 2, 2023 10:16
holtgrewe
holtgrewe requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@holtgrewe holtgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you merge with the upstream merged change / resolve conflicts?

might already be done in current head, though

@sellth
Copy link
Collaborator Author

sellth commented Jan 16, 2024

fixed in #113

@sellth sellth closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtgrewe holtgrewe holtgrewe requested changes

@mkuhring mkuhring Awaiting requested review from mkuhring mkuhring is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvestigationReader fails to properly report missing sections at EOF
2 participants
@sellth @holtgrewe