Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectView.java: Deleting the secondary "Add Rank" in the edit menu. #37

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

dmk257
Copy link
Collaborator

@dmk257 dmk257 commented Jul 4, 2024

The "Add Rank" button in the edit menu had a different behavior than the main button (it did not cancel in progress commands). Rather than supporting both, I've elected to remove the one in the edit menu, since most users will likely just use the button directly in front of them.

The "Add Rank" button in the edit menu had a different behavior than the
main button (it did not cancel in progress commands).  Rather than
supporting both, I've elected to remove the one in the edit menu, since
most users will likely just use the button directly in front of them.
@dmk257 dmk257 requested a review from vdye July 4, 2024 17:31
Copy link
Contributor

@vdye vdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever used the Edit menu "Add Rank" option, the main view one is more intuitive anyway. And thanks for moving the tooltip to the main view.

Looks good to me!

@vdye vdye merged commit 81d1ca3 into bigredbands:main Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants