Add AOSmith and LG models #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith-and-LG-models
|
This is looking good. Is it ready for review or still in "draft"? |
|
Ready to merge. |
nealkruis
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined branches with new AOSmith-HPTS40 and LG-APHWC50 models.
The LG model was refined to match provided test data. The AOSmith model was implemented using provided tank parameters; other parameters were left unchanged. Simulations for both were run in Hsim and cse.
Improvements were made to python scripts for extraction of test schedules and measured data. Improved setting default values in webpage used for plot visualization.
Some initial organization with the test folder was made to accommodate the growing collections of tests from various vendor.