-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write test outlet temperature #187
Conversation
src/HPWHpresets.cc
Outdated
@@ -515,7 +515,7 @@ int HPWH::HPWHinit_presets(MODELS presetNum) { | |||
|
|||
else if (presetNum == MODELS_StorageTank) { | |||
setNumNodes(12); | |||
setpoint_C = 800.; | |||
setpoint_C = F_TO_C(127.); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem relevant to this branch.
test/main.cc
Outdated
else if(var1 == "writeOutletT") { | ||
writeOutletT = (bool)testVal; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs the latest master merged in still, but otherwise good to go.
CSVOPT_NONE = 0, | ||
CSVOPT_IPUNITS = 1 << 0, | ||
CSVOPT_IS_DRAWING = 1 << 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little weird, but since whether the system is drawing or not is a row-level property (not a whole CSV level property). It's not critical at this point to clean up this code, though.
Description
Author Progress Checklist:
Reviewer Checklist: