Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extra heat method #185

Merged
merged 20 commits into from
Dec 11, 2023
Merged

Change extra heat method #185

merged 20 commits into from
Dec 11, 2023

Conversation

spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Dec 5, 2023

Description

  • Changes the method for applying extra heat. Extra heat is specified by a pointer to a std::vector when calling runOneStep. Formerly, extra heat was (vaguely) associated with a HeatSource member of a HPWH object. This PR removes this association.
  • Previously, an extra-heat vector of size N specified power to the lowest N tank nodes. It now represents a full power distribution of arbitrary size across the tank height.
  • These changes were tailored to match the the original method by calculating a modified, thermal distribution based on tank parameters, rather than directly using the specified distribution itself. Apparently, this reduces "swoopiness".
  • No changes were made in this branch to conserve energy, which are address in a different PR.
  • This branch passes all HPWH tests. It will cause failure of the cse test dhwsolar.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • [] Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@spahrenk spahrenk self-assigned this Dec 5, 2023
@spahrenk spahrenk marked this pull request as ready for review December 11, 2023 20:13
@nealkruis nealkruis merged commit bfd31a3 into master Dec 11, 2023
2 checks passed
@nealkruis nealkruis deleted the change-extra-heat-method3 branch December 11, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants