Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang format #3

Closed
wants to merge 5 commits into from
Closed

Add clang format #3

wants to merge 5 commits into from

Conversation

tanaya-mankad
Copy link

Apply .clang-format to all source files; add CI task to check formatting upon push.

@tanaya-mankad tanaya-mankad added the enhancement New feature or request label Oct 23, 2023
@tanaya-mankad tanaya-mankad self-assigned this Oct 23, 2023
Copy link

@spahrenk spahrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want BreakBeforeBraces: Stroustrup?

@tanaya-mankad
Copy link
Author

We don't want BreakBeforeBraces: Stroustrup?

Nope. Stroustrup won't line up the braces except for functions.

@spahrenk
Copy link

We don't want BreakBeforeBraces: Stroustrup?

Nope. Stroustrup won't line up the braces except for functions.

That's what I'm asking. You used Stroustrup in btwxt.

@tanaya-mankad
Copy link
Author

Oh yeah, thanks for the reminder. There are a lot of settings so it's entirely likely well miss some until we see them! InsertBraces is another one. I made the change in atheneum, so we'll propagate to everything soon.

@nealkruis
Copy link
Member

What's going on with the failed checks?

@tanaya-mankad
Copy link
Author

What's going on with the failed checks?

Stupidity. I forgot to run the new clang-format before I checked it in!

@nealkruis nealkruis closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants